kossebau added inline comments.

INLINE COMMENTS

> KDEInstallDirs.cmake:131
>  #     autostart files (``CONFDIR/autostart``) [``AUTOSTART_INSTALL_DIR``]
> +# ``DEBUGCATEGORIESDIR``
> +#     kdebugsettings categories files directory 
> (``DATAROOTDIR/debug-categories5``) Since 5.59.0

Might `LOGGINGCATEGORIESDIR` or perhaps short `LOGCATDIR`  not be a better 
name, for one more following the naming pattern of Qt, but also more clearly 
pointing out what this is about? Debug categories could mean a lot, while this 
here is about logging only.

> KDEInstallDirs.cmake:132
> +# ``DEBUGCATEGORIESDIR``
> +#     kdebugsettings categories files directory 
> (``DATAROOTDIR/debug-categories5``) Since 5.59.0
>  #

given this is adding a dir in the shared naming area, could this perhaps be 
more specific named, unless the plan is to make this a general-purpose dir 
shared among all kind of applications & toolkits?
For now this data is only for one program, kdebugsettings, so IMHO that should 
be reflected here.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

Reply via email to