anthonyfieroni added inline comments. INLINE COMMENTS
> batchrenametypes.cpp:98-106 > +QStringList firstCapturedGroups() > +{ > + return capturedGroups; > +} > + > +void clearCapturedGroups() > +{ Make a class instead, free functions with global variable in, is no-go. It's totally miss of encapsulation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns