ngraham added a comment.
Nice! What do you think about moving the `if (configGroup && itemView) {`
into the new function and calling it something more conditional, like
`writeIconZoomSettingsIfNeeded`? Also it seems like there could be some code
shared in a new function so that `KDirOperator::Private::iconSizeForViewType()`
and `KDirOperator::Private::writeIconZoomSettings()` don't have to have so much
duplicated code. They're both in the same scope so they have access to the same
set of variables which should hopefully make it possible.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D21459
To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
