bruns added a comment.
In D21379#471513 <https://phabricator.kde.org/D21379#471513>, @broulik wrote: > So, you want me to change that `1` to `QVariant()` then? I think that is completely sufficient, yes. In all the other places, the `!QVariant::toString().isEmpty()` and `QVariant::toInt() == 1` should be replaced by just `QVariant::isValid()` REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
