nicolasfella added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:140
> if (action == QLatin1String("Popup")) {
> -#ifndef Q_OS_ANDROID
> - if (d->portalDBusServiceExists) {
> - plugin = new NotifyByPortal(this);
> - } else {
> - plugin = new NotifyByPopup(this);
> - }
> -#else
> - plugin = new NotifyByAndroid(this);
> -#endif
> -
> + #if defined(Q_OS_ANDROID)
> + plugin = new NotifyByAndroid(this);
No space before macro
> brute4s99 wrote in notifybysnore.cpp:44
> Yep! In
> https://piyushagg.home.blog/2019/06/07/gsoc19-project-milestone-1/
This should be documented somewhere else, too. Either the API dox or the KDE
wiki
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D21661
To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham,
bruns
