ilic added inline comments.
INLINE COMMENTS
> klocalizedstringtest.cpp:222
> +
> + QLocale::setDefault(QLocale(QLocale::French));
> + QCOMPARE(ki18n("%1").subs(4.2, 5, 'f', 2).toString(),
The French locale is already being set in line 45 using setlocale, for which
the system has to have fr_FR.utf8 glibc locale installed. Any further setting
up of locale details, if needed, should happen in lines 70-76, which are
currently commented out with "until locale system is ready" (and if not needed,
this whole commented out part should be deleted).
> klocalizedstringtest.cpp:226
> +
> + QLocale::setDefault(QLocale(QLocale::English, QLocale::UnitedStates));
> QCOMPARE(ki18n("%1").subs(4.2, 5, 'f', 2).toString(),
The tests work with French locale, there is no reason introduce English here
only. It also clobbers the globaly set locale elements in initTestCase.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D22069
To: ngraham, #localization, #frameworks, broulik
Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n,
michaelh, ngraham, bruns
