dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
A video showing the feature, in the merge request! I'm blown away!
Code looks fine.
INLINE COMMENTS
> kxmlguibuilder.cpp:349
> + } else if (tagName == d->tagSpacer) {
> + if (KToolBar *bar = qobject_cast<KToolBar *>(parent)) {
> + // Create the simple spacer widget
(pre-existing, in the separator code above) QToolBar would be sufficient,
technically, in this code.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22609
To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron,
michaelh, bruns
