apol added a comment.
In D22723#501690 <https://phabricator.kde.org/D22723#501690>, @fvogt wrote: > Looks like a hack still, with two Job objects for each job... > > What about just merging `QObjectDecorator` into `FindMatchesJobInternal` by basically just adding a custom `done` signal and ignoring the entire "decorators which are actually wrappers" business? > > IMO this new `FindMatchesJobInternal` class makes it even less obvious what's actually going on. This is how ThreadWeaver and especially QObjectDecorator is meant to be used. I don't really know why you say it's confusing. The confusing part so far was that jobDone slot was never called. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D22723 To: apol, #frameworks, fvogt, davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
