cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed.
I appreciate the removal of the fallthrough=bool attribute. Given it is sematic-free if no fall through context is there I guess this is a "compatible" change. But please update the XSD (there are even some comments about fallthrough being dubious) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23034 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
