cgiboudeaux added inline comments.

INLINE COMMENTS

> KF5SyntaxHighlightingConfig.cmake.in:4-5
> +include(CMakeFindDependencyMacro)
> +find_dependency(Qt5Core @Qt5Core_VERSION_MAJOR@.@Qt5Core_VERSION_MINOR@)
> +find_dependency(Qt5Gui @Qt5Core_VERSION_MAJOR@.@Qt5Core_VERSION_MINOR@)
>  

Please use REQUIRED_QT_VERSION defined in the top CMakeLists.txt instead of 
these Qt5Core_VERSION_*

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23208

To: daandemeyer, #framework_syntax_highlighting, dhaumann
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

Reply via email to