sredman accepted this revision.
sredman added a comment.
This revision is now accepted and ready to land.
Since KNotifications on Windows is so far only used by you anyway, I say it's
fine to merge. @broulik, any objections?
INLINE COMMENTS
> notifybysnore.cpp:157
> + notification->pixmap().save(iconPath, "PNG");
> + arguments << QStringLiteral("-p") << iconPath;
> + } else if (!qApp->windowIcon().isNull()){
Whitespace
> notifybysnore.cpp:160
> + QIcon app_icon = qApp->windowIcon();
> + // We limit the icon size to 1024x1024 as it is the highest supported by
> Windows
> + QPixmap pixmap = app_icon.pixmap(app_icon.actualSize(QSize(1024,
> 1024)));
Indentation
REPOSITORY
R289 KNotifications
BRANCH
arcpatch-D23196
REVISION DETAIL
https://phabricator.kde.org/D23196
To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
