zzag added inline comments.
INLINE COMMENTS
> kwindowsystem.cpp:458
>
> +static QWindow* setMainWindowHelper(QWindow *subWindow, WId mainWindowId)
> +{
Coding style: For pointers or references, use a single space before '*' or '&',
but not after.
https://techbase.kde.org/Policies/Frameworks_Coding_Style#Whitespace
> kwindowsystem.cpp:490
> +{
> + (void) setMainWindowHelper(subWindow, mainWindowId);
> }
Each time this method is called a new foreign QWindow object will be created.
Can you please explain why leaking those objects is okay?
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D23108
To: dfaure, broulik, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
