asemke added inline comments. INLINE COMMENTS
> ltoscano wrote in kxmlgui_unittest.cpp:1089 > Declensions: > https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension there is no declension in Russian for the nominative case. The name of the month is январь and not января, but it is первого января (on January 1st) and not первого январь. https://doc.qt.io/qt-5/qlocale.html#monthName - QLocale must return the name of the month, meaning the nominative case and not one of its declensions. > aacid wrote in kxmlgui_unittest.cpp:1089 > Yes, it may surprise you, but i did actually run the tests before submitting > this code change. The question was rethoric. I was rather surprised about the validnes of the check you did here. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23119 To: aacid Cc: apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, ngraham, bruns
