elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> krichtextwidget.cpp:638
>
> - if (linkDialog->exec()) {
> + if (linkDialog->exec() && linkDialog) {
> q->updateLink(linkDialog->linkUrl(), linkDialog->linkText());
This should be `linkDialog && linkDialog->exec()`
> ktextedit.cpp:369
> }
> - if (dialog.exec()) {
> - setSpellCheckingLanguage(dialog.language());
> + if (dialog->exec() && dialog) {
> + setSpellCheckingLanguage(dialog->language());
Same here, we need to check the pointer before using it.
REPOSITORY
R310 KTextWidgets
REVISION DETAIL
https://phabricator.kde.org/D21897
To: pajamapants3000, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
