ahmadsamir added a comment.

  Maybe they'll also see it as ktexteditor/kate using a regex engine that 
matches what the abundance of online pcre docs say, and how other editors that 
use pcre behave?
  
  IIUC, '\s' was workedaround so as not to match a newline so that the search 
pattern wouldn't be considered multiline (isMultiLine() function), which makes 
findAll and replaceAll slower as it took longer, v.s. just matching against 
each line separately.
  
  The thing is, what kateregexp did was replace '\s' with '[ \t]', which users 
who want this behaviour can easily use.
  
  Technically it's a whole new class, QRegularExpression, some different 
behaviours are sort of expected...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23457

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

Reply via email to