sitter updated this revision to Diff 64744. sitter added a comment.
- wrap in custom assert defines that either assert or qwarn based on a cmake option - new cmake option KIO_ASSERT_SLAVE_STATES enables the asserts. the option is only on by default when run on jenkins - fix a bunch of typos the long term plan here is still to always enable the assertions (conditional on build type anyway), to not break everyones systems the cmake option allows a few brave souls to opt into assertion. also by running jenkins slaves with assertions we'll have additional chances of finding bugs there REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23344?vs=64294&id=64744 BRANCH assert REVISION DETAIL https://phabricator.kde.org/D23344 AFFECTED FILES CMakeLists.txt src/core/config-kiocore.h.cmake src/core/slavebase.cpp To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns