broulik added inline comments. INLINE COMMENTS
> slavebase.h:343 > + */ > + QMap<QString, QString> *mapConfig(); > + Why return a pointer, and why is this method not `const`? Or is this supposed to be writable? Then I would prefer returning a reference to communicate ownership properly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns