pino added a comment.
Please move the implementations in the cpp file, otherwise it will be impossible to change/fix the implementation later on in a binary compatible way. Also: - both the operators ought to be const, since they do not mutate the object (and otherwise they cannot be used to compare const objects) - please fix the style in the declarations: `const UDSEntry& other` -> `const UDSEntry &other` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
