dfaure added a comment.
This broke the unittest in CI. https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.12/35/testReport/junit/projectroot/autotests/ki18n_klocalizedstringtest/ I can reproduce the failure locally. FAIL! : KLocalizedStringTest::correctSubs() Compared values are not the same Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20" Expected (QString(" 4,20")) : " 4,20" Loc: [/d/kde/src/5/frameworks/ki18n/autotests/klocalizedstringtest.cpp(225)] REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik, aacid Cc: dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns
