jgrulich added inline comments. INLINE COMMENTS
> fakeinput.h:222 > + * Request a keyboard button release. > + * @param linuxButton The button code as defined in > linux/input-event-codes.h > + * I will need a little bit of help to understand what type of key event should be used and I don't remember where I got the information it expects codes defined from linux/input-event-codes.h (I copied it from the previous review) Anyway, for the remote desktop portal, we will need to support both keysym and keycodes [1]. [1] - https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.impl.portal.RemoteDesktop.xml#L226 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns