dfaure created this revision. dfaure added reviewers: cfeck, dhaumann, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision.
REVISION SUMMARY the QComboBox::activated(QString) signal being deprecated and optionally non-existent makes this interesting in subclasses trying to emit it. TEST PLAN -DQT_DISABLE_DEPRECATED_BEFORE=0x060000, make, ctest and playing a bit with kcompletionuitest. REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D23842 AFFECTED FILES autotests/kcombobox_unittest.cpp src/kcombobox.cpp src/kcompletion.cpp src/kcompletionbox.cpp src/khistorycombobox.cpp src/klineedit.cpp src/ksortablelist.h tests/kcompletionuitest.cpp To: dfaure, cfeck, dhaumann, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns