bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fstabhandling.cpp:236
> + auto device = it.key();
> + QString deviceName = device;
> + if (deviceName.endsWith(QLatin1Char('/'))) {
You should check for `devices.contains(deviceName)` here and `continue`, avoids
detaching deviceName when not necessary.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21204
To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol,
kde-frameworks-devel, LeGast00n, GB_2, michaelh
