zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > dfaure wrote in test_wayland_surface.cpp:396 > The "Almost Always Auto" crowd would disagree with you, but sure, your > choice. Done. Putting auto everywhere is a terrible thing! Surely it makes refactoring a bit easier, however you kill readability by erasing types. Qt has a really good auto keyword usage guideline. https://wiki.qt.io/Coding_Conventions#auto_Keyword REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D24014 To: dfaure, davidedmundson, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns