kossebau added a subscriber: chehrlic. kossebau added a comment.
@chehrlic Hi. As I just discovered, you are the author of the macros for Qt (commit <https://gitlab.com/thiagomacieira/qtbase/commit/bbf04184be1adbe7564a95d45904fe485cd33d22>) which I took as inspiration/blue print when designing this here. So, curious what you think of your work now and if you can already point out things where you see potential for improvements. And also curious what you think of this approach here :) Actual questions I have: - why is QT_DEPRECATED_WARNINGS_SINCE not officially documented? like, any plans to change that macro to something else? - why has all Qt code not yet been adapted to QT_DEPRECATED_VERSION/QT_DEPRECATED_VERSION_X, are there places where those macros should not be used, but the version-less ones? - why did you go for both QT_DEPRECATED_VERSION & QT_DEPRECATED_VERSION_X, are there places where no message will be wanted? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
