kossebau added a comment.
Will see to give this some review later this week (if still needed). Would agree the "modern" code is more easy to grasp by humans and thus better to maintain, so +1 for principle. All override changes please as separate commit though, unrelated to commit message (IMHO can go in directly). Do we already have agreed on using override with destructors in KF code I do prefer them as well). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24160 To: dfaure, bruns, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
