ndavis added a comment.

  In D24253#538662 <https://phabricator.kde.org/D24253#538662>, @trickyricky26 
wrote:
  
  > Visually I think this is fine and a good improvement.
  >
  > I wonder why your SVGs have two seperate paths as opposed to unifying them 
into one path (as I usually do)? Just curious if there is any benefit to using 
one approach above the other.
  >  Also, judging by the MDN Page 
<https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/fill-rule> I don't 
think the `fill-rule="evenodd"` does anything here.
  
  
  Sometimes the optimizers prefer to group rather than combine. These days, 
optimization is used to keep diffs readable so I can find mistakes and to cut 
down the size most of the way. Optimizing down to the last byte we can get rid 
of is not necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24253

To: ndavis, #vdg
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Reply via email to