sandsmark created this revision. sandsmark added reviewers: aacid, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sandsmark requested review of this revision.
REVISION SUMMARY Since QImage does sanity checking for overflows and stuff wrt. dimensions and depth, check for QImage::isNull() as early as possible to see if there's some funky business going on. Also tried to add some checks wherever we wrote to "raw" memory. TEST PLAN Unit tests pass, and tested converting some files from https://samples.ffmpeg.org/image-samples/ to pngs, and that seemed to work. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24367 AFFECTED FILES src/imageformats/exr.cpp src/imageformats/pcx.cpp src/imageformats/pic.cpp src/imageformats/psd.cpp src/imageformats/rgb.cpp src/imageformats/tga.cpp To: sandsmark, aacid, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns