usta added inline comments. INLINE COMMENTS
> kformatprivate.cpp:339 > > - int hours = ms / MSecsInHour; > + const qint64 hours = ms / MSecsInHour; > ms = ms % MSecsInHour; why dont we use quint64 in here ? > kformatprivate.cpp:470 > quint64 ms = msecs; > int days = ms / MSecsInDay; > ms = ms % (MSecsInDay); same problem here ( quint64 days and hours ) ( maybe not days but hours ) also days, hours , minutes and seconds also can be conts in here too REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24400 To: aacid Cc: usta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns