GB_2 added inline comments. INLINE COMMENTS
> ppeter wrote in executablefileopendialog.cpp:58 > if (mode == OnlyExecute) > connect(executeButton, ...) > else if (mode == OpenAsExecute) > ... > > looks better :) That would be against the common KDE coding style: https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns