kossebau updated this revision to Diff 67718. kossebau added a comment.
fix incompleteness of patch WRT to NET::Override While that flag is deprecated for clients, window managing code seems to still need to handle that flag if set by old clients, so tagging it as deprecated might result in premature removal of the support. That needs a separate plan how to make sure it#s no longer used out in the wild by clients. lxr.kde.org reports it still with some application code REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24465?vs=67428&id=67718 BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24465 AFFECTED FILES CMakeLists.txt autotests/kstartupinfo_unittest.cpp autotests/kwindowsystemx11test.cpp autotests/kxmessages_unittest.cpp autotests/netwininfotestclient.cpp src/CMakeLists.txt src/kstartupinfo.cpp src/kstartupinfo.h src/kwindoweffects.cpp src/kwindoweffects.h src/kwindowsystem.cpp src/kwindowsystem.h src/kwindowsystem_dummy_p.h src/kwindowsystem_p.h src/netwm_def.h src/platforms/osx/kwindowsystem.cpp src/platforms/wayland/kwindowsystem.cpp src/platforms/wayland/kwindowsystem_p_wayland.h src/platforms/windows/kwindowsystem.cpp src/platforms/xcb/kkeyserver.cpp src/platforms/xcb/kkeyserver_x11.h src/platforms/xcb/kwindowsystem.cpp src/platforms/xcb/kwindowsystem_p_x11.h src/platforms/xcb/kxmessages.cpp src/platforms/xcb/kxmessages.h src/platforms/xcb/netwm.cpp src/platforms/xcb/netwm.h To: kossebau, #frameworks, #kwin, dfaure, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns