trickyricky26 requested changes to this revision. trickyricky26 added a comment. This revision now requires changes to proceed.
Before this is can be landed, you will have to also add/change the Konsole and Yakuake icons in the icons-dark directory. While I think these icons do look nice on their own and I quite like the clever design of the Yakuake Prompt / "Y" symbol, I don't think they fit the Breeze icon style very well. I think they are too boxy and flat (even though you used gradients) to fit in. I would suggest you try to use more slim lines, similar to the current Konsole icon, as well as gradients with bigger differences between the colors. In D24621#546750 <https://phabricator.kde.org/D24621#546750>, @ndavis wrote: > Maybe something like this? I'm not sure. F7592258: Screenshot_20191014_011043.png <https://phabricator.kde.org/F7592258> F7592287: konsole.svg <https://phabricator.kde.org/F7592287> I think these tabs look more Breeze-y, but still the icon looks quite flat and imo the thickness of the prompt symbol does not look right for a Breeze icon. In D24621#546750 <https://phabricator.kde.org/D24621#546750>, @ndavis wrote: > I think the K in most of the Konsole variants is a bit too much and I think it would be too distracting. It's not immediately obvious that it's a K. When I look at it, the first thing my eyes see is "**>**__|**<**__", rather than "**>**__K__", which is confusing. IIRC the discussion about the redesign of these icons started with the problem that they are not recognizable enough as standalone apps, not just as genric terminal emulators. I think we should try to experiment some more with the "K" symbol until we maybe find a variant that we like and fits well enough with other Breeze icons. Otherwise, I don't necessarily think F7592258: Screenshot_20191014_011043.png <https://phabricator.kde.org/F7592258> or one of the variant B icons will be an improvement over the current Konsole icon, which I personally like because of it's simplicity. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24621 To: mglb, #vdg, #konsole, #yakuake, trickyricky26 Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
