dfaure added a comment.
Do we want these, found in https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format? # We use template< without space. SpaceAfterTemplateKeyword: false # macros for which the opening brace stays attached. ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH, forever, Q_FOREVER, QBENCHMARK, QBENCHMARK_ONCE ] # Break constructor initializers before the colon and after the commas. BreakConstructorInitializers: BeforeColon In general, I'm curious why we're not using qt5's clang-format file, with our only difference (braces for single-line statements) on top? INLINE COMMENTS > clang-format.cmake:42 > + > +# sematics shall be grouped via empty lines > +SortIncludes: true Typo: semantics > clang-format.cmake:43 > +# sematics shall be grouped via empty lines > +SortIncludes: true > + I'm confused because here it says "true" will group via empty lines, while https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format says `the SortInclude feature of clang-format does not re-order includes separated by empty lines`. Maybe different versions of clang-format? Or I misunderstand something? > clang-format.cmake:49 > +# CrlInstruction *a; > +PointerAlignment: Right > + https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format says `PointerBindsToType: false`, what's the difference? > clang-format.cmake:75 > + > +# don't break tenary ops > +BreakBeforeTernaryOperators: false typo: ternary REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure Cc: mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
