davidedmundson added a comment.
GB_2's comment needs fixing, two strings are out of sync. Other than that, ship it. INLINE COMMENTS > GB_2 wrote in corona.cpp:502 > Missing ellipsis (...) Given how easy it is to get these out of sync, can I suggest removing all the code to update editAction's text from Corona::setEditMode and put it in a connect here. It'll keep the editAction logic altogether. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg, ngraham Cc: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
