meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS
> elvisangelaccio wrote in trashimpl.cpp:1091 > Is this really needed? We just created `entry`. It was done previously in void TrashProtocol::createTopLevelDirEntry to save some memory, so I just kept it here and line 500. Although it is not very useful. > elvisangelaccio wrote in trashimpl.cpp:1094 > coding style: local variables never start with an uppercase. TrashedFileInfoList is the type of TrashedFileInfoList, no issue with codding style. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
