aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  ok, fair enough about the tests

INLINE COMMENTS

> sitter wrote in kshortcuteditwidget.cpp:72
> it's initialized to None via the ctor at line 68 already. now that I notice 
> it, defaultText could also be const now.

ah right.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to