aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision.
REVISION SUMMARY I wasn't 99% sure we need to free the filters so early since we're passing them to the functions that manipulate the streams, but having a look at various other code using lzma they also free them very early and the fact that everything still works is also a good indicator TEST PLAN Before valgrind --leak-check=full karchivetest gave memory leaks, now it does not REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D24938 AFFECTED FILES src/kxzfilter.cpp To: aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
