ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision.
REVISION SUMMARY If the user types some text in the lineEdit and there's more than one match in the model view, don't automatically select the first match, so that if the user presses Enter/Return, we don't load the first result as it could well be not what the user actually wants. BUG: 400725 TEST PLAN - Make sure ark and wireshark are installed on your system - Invoke the open-with dialog on any archive file, and type ark - You should get two results (or three if Ark is present in two individual categories on your system...) WireShark and Ark, with the former being automatically selected for you - Press Enter, the file is opened with wireshark - Apply the diff then try again, the open-with dialog will not select the first result, and if you press Enter the dialog will open the file using the command you typed REPOSITORY R241 KIO BRANCH l-kopenwithnondeterministic (branched from master) REVISION DETAIL https://phabricator.kde.org/D24951 AFFECTED FILES src/widgets/kopenwithdialog.cpp To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
