meven added a comment.

  In D25216#560212 <https://phabricator.kde.org/D25216#560212>, @aspotashev 
wrote:
  
  > LGTM since it fixes the issue.
  >
  > A next step could be a clearer explaination of what $GenericName will be 
replaced with. Is it always replaced with Filelight's GenericName from its 
filelight.desktop file?
  
  
  Yes, it uses KMoreToolsService::formatString to replace $GenericName with 
content from its desktop file.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D25216

REVISION DETAIL
  https://phabricator.kde.org/D25216

To: meven, leinir, ngraham, #localization, aspotashev
Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to