kmaterka added a comment.
In D25223#561570 <https://phabricator.kde.org/D25223#561570>, @davidedmundson wrote: > I had this. I abandoned because we ended up forking some special wayland stuff in our DBus menu, so would always want our implementation. > > > ?https://codereview.qt-project.org/c/qt/qtbase/+/168458 Having an option to fallback to default/predefined theme would be great, but I guess KDE needs to have it's own SystemTray implementation anyway (?). Some cleanup is required, because currently: - in Plasma-integration (QPA theme): - there is a forked QDBusMenuBar from Qt - for tray icon it uses KStatusNotifierItem which has it's drawbacks (additional layer) - in KNotifications, KStatusNotifierItem uses libdbusmenu-qt (not forked). It is optional dependency, is there any reason for that in 2019? - in plasma-workspace StatusNotifierItemSource uses DBusMenuImporter forked from libdbusmenu-qt - Qt has it's own implementation of DBus menu exporter: - in genericunix qpa theme, unfortuantelly QDBusPlatformMenu is private - it uses undocumented "NewMenu <https://github.com/qt/qtbase/commit/ff169e8859457188f94aed86368876ba5bab2e90>" signal - and is buggy: QTBUG-79287 <https://bugreports.qt.io/browse/QTBUG-79287>, KDE 383202 <https://bugs.kde.org/show_bug.cgi?id=383202> - libdbusmenu-qt was not actively updated/maintained for years, I see that David made few commits in 2015. Shouldn't DBusMenuImporter be upstreamed? - Freedesktop spec <https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/> is still in draft phase Anyway, this is not part of this code review, sorry for the off topic. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, broulik Cc: nicolasfella, davidedmundson, cgiboudeaux, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
