feverfew marked 8 inline comments as done. feverfew added inline comments. INLINE COMMENTS
> sitter wrote in desktopexecparser.cpp:317 > There's nothing wrong with this. But wouldn't using > `QHash<QDBusPendingReply<QString>, QUrl>` make for easier to read code all in > all since you don't have to mess with pairs? > > Alternatively with a vector I'd still make a struct for the data > > struct MountRequest { QDBusPendingReply<QString> reply, QUrl url }; > QVector<MountRequest> requests; > ... > requests.push_back({ mountUrl(url), url }); Gone for the vector option. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns