bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fstabhandling.cpp:301
> +
> +void Solid::Backends::Fstab::FstabHandling::parseMtabFile(const QString&
> mtabPath, QMultiHash<QString, QString>& activeMounts, QHash<QString,
> QString>& activeFstype)
> +{
The API is totally awkward.
You end up with something significantly cleaner when you create a new class for
it:
QStringMultiHash m_mtabCache;
QHash<QString, QString> m_mtabFstypeCache;
bool m_mtabCacheValid;
and make the parser a member function.
Then instantiate the class for the fuseiso case and for the globalFstabCache.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21235
To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
