cfeck added a comment.
Since KAssistantDialog is a KPageDialog, what happens to other users of that class? I had hoped the fix is in KPageDialog, and it would only omit the margins when the caller requested it (e.g. KCMs etc.). INLINE COMMENTS > kassistantdialog.cpp:103 > + q->pageWidget()->layout()->setContentsMargins( > + style->pixelMetric(QStyle::PM_LayoutLeftMargin), > + style->pixelMetric(QStyle::PM_LayoutTopMargin), Please also pass styleOptions and widget. Some styles might compute margins from font sizes, and without any context, they can only assume defaults. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25444 To: ngraham, #frameworks, cfeck, mart Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
