guoyunhe added a comment.
I also think these *.menu and *.directory files should not be required at compile time. And they should better be in same repository because they are connected so closely. In this patch, we added a new file `kf5-network.directory` in plasma-workspace and reference it here. But this means frameworks 5.65 will depend on plasma-workspace 5.18. Any other combination, like frameworks 5.65 + plasma 5.17 or frameworks 5.64 + plasma 5.18, will break. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: davidedmundson, ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
