apol added a comment.

  This patch is changing the logic. I'd recommend changing the commit message 
to reflect it.

INLINE COMMENTS

> CMakeLists.txt:150
>  add_subdirectory( about )
> -if(KF5Activities_FOUND)
> +if(KF5Activities_FOUND AND Qt5Sql_FOUND)
>    add_subdirectory( activities )

I'd say it's better to use `...AND TARGET Qt5::Sql)`

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25528

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Reply via email to