davidedmundson added inline comments.
INLINE COMMENTS
> provider.cpp:1632
> + if (QCoreApplication::instance()) {
> + agentHeader =
> QString::fromLocal8Bit("%1/%2").arg(QCoreApplication::instance()->applicationName()).arg(QCoreApplication::instance()->applicationVersion());
> + } else {
string.arg(foo, bar)
not
string.arg(foo).arg(bar)
otherwise we explode if foo contains the string "%1"
> provider.cpp:1634
> + } else {
> + agentHeader = QString::fromLocal8Bit("Attica/%1");
> + }
where does %1 get set?
(same for the %2 below)
REPOSITORY
R235 Attica
REVISION DETAIL
https://phabricator.kde.org/D25440
To: leinir, #frameworks, #knewstuff, #plasma, starbuck, ronaldv
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
