ahmadsamir updated this revision to Diff 70379. ahmadsamir marked 5 inline comments as done. ahmadsamir added a comment.
- Keep I18NC_NOOP working - QLatin1String where appropriate - Rename mProtocolToStr() to protocolName(), and make it private (only used in slavebase) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24349?vs=70271&id=70379 BRANCH arcpatch-D24349 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24349 AFFECTED FILES src/core/forwardingslavebase.cpp src/core/kremoteencoding.cpp src/core/slavebase.cpp src/core/slavebase.h src/filewidgets/kencodingfiledialog.cpp src/filewidgets/kfileplacesmodel.cpp src/ioslaves/ftp/CMakeLists.txt src/ioslaves/ftp/ftp.cpp src/kcms/kio/kcookiespolicies.cpp src/kcms/kio/smbrodlg.cpp src/kioexec/main.cpp src/kpasswdserver/autotests/CMakeLists.txt src/kpasswdserver/autotests/kpasswdservertest.cpp To: ahmadsamir, dfaure, #frameworks Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
