kossebau added a comment.
Looks correct from deprecation-markup POV. Did you do a test build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.65.0, to check if any tests or examples still use the deprecated signals and need some additions of #if KWIDGETSADDONS_ENABLE_DEPRECATED_SINCE(5, 65) in places? When it comes to deprecated signals, seems those overloads have been present since introduction of KUrlLabel. Not sure about the usefulness of passing the url as argument with any signals, given that the url is a static property of the label, only set via the setter setUrl(). Have you checked how the respective signals are used? Are there similar classes, what signals do they have? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25561 To: mlaurent, dfaure, kossebau Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
