ahiemstra marked an inline comment as done. ahiemstra added inline comments.
INLINE COMMENTS > kossebau wrote in kcolumnheadersmodel.h:57 > For consistency I would prefer having a full Q_SIGNALS section: > > Q_SIGNALS: > void sourceModelChanged(); > > That matches the usual pattern and helps when reading raw headers to learn > about API of classes. I actually prefer the combined style since it groups together all related bits regarding a single property. But I've changed it to a separate section now. > kossebau wrote in kcolumnheadersmodel.h:60 > Why not QScopedPointer (for consistency in KF code)? Is that one going to be > deprecated in favour of std::unique_ptr? Mostly force of habit. I also see little point in using QScopedPointer nowadays, as it does not offer anything over std::unique_ptr. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25311 To: ahiemstra Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns