ngraham created this revision. ngraham added reviewers: leinir, Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision.
REVISION SUMMARY Using `.arg()` in `i18n()` calls can lead to runtime errors such as the ones shown in https://bugs.kde.org/show_bug.cgi?id=414498. Let's port away from that. BUG: 414498 TEST PLAN QML GHNS dialog no longer has any i18n errors in strings REPOSITORY R304 KNewStuff BRANCH fix-i18n-usage (branched from master) REVISION DETAIL https://phabricator.kde.org/D25585 AFFECTED FILES src/attica/atticaprovider.cpp src/qtquick/qml/Dialog.qml src/qtquick/qml/EntryDetails.qml src/qtquick/qml/private/EntryCommentDelegate.qml src/qtquick/qml/private/EntryCommentsPage.qml src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml src/qtquick/quickitemsmodel.cpp To: ngraham, leinir, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns