dfaure added inline comments. INLINE COMMENTS
> meven wrote in directorysizejob.cpp:137 > The previous code did (details of 3) I'm confused by what you mean here... and I think I found more problems: Indeed the old code used 3. In your patch, you changed this to 2, in the legacy field for old kioslaves; any reason for that? "3" adds UDS_DEVICE_ID/UDS_INODE which are used on lines 154/157 here. Surely we want to keep using 3. And this means, in the new field statDetails, we want to specify KIO::Inode to get those fields. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
